Skip to content

Commit

Permalink
Merge pull request #452 from bwoodsend/simplify-manylinux
Browse files Browse the repository at this point in the history
Remove explicit handling of manylinux platform tag
  • Loading branch information
hugovk committed Feb 24, 2021
2 parents 7cceea1 + 235d192 commit 27b82c8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy-wheels.yml
Expand Up @@ -70,8 +70,8 @@ jobs:
- name: Build x86 Linux wheels
if: matrix.wheel == 'x86'
run: |
docker run -e PLAT=manylinux1_x86_64 -v `pwd`:/io quay.io/pypa/manylinux1_x86_64 /io/scripts/build-manylinux-wheels.sh
docker run -e PLAT=manylinux1_i686 -v `pwd`:/io quay.io/pypa/manylinux1_i686 /io/scripts/build-manylinux-wheels.sh
docker run -v `pwd`:/io quay.io/pypa/manylinux1_x86_64 /io/scripts/build-manylinux-wheels.sh
docker run -v `pwd`:/io quay.io/pypa/manylinux1_i686 /io/scripts/build-manylinux-wheels.sh
- name: Upload as build artifacts
uses: actions/upload-artifact@v2
Expand Down
1 change: 0 additions & 1 deletion scripts/Dockerfile_aarch64
@@ -1,6 +1,5 @@
FROM quay.io/pypa/manylinux2014_aarch64 as build

ENV PLAT=manylinux2014_aarch64
RUN mkdir -p /io/
COPY . /io/
WORKDIR /io/
Expand Down
7 changes: 2 additions & 5 deletions scripts/build-manylinux-wheels.sh
Expand Up @@ -4,10 +4,7 @@ set -e -x
# This is to be run by Docker inside a Docker image.
# You can test it locally on a Linux machine by installing Docker and running from this
# repo's root:
# $ docker run -e PLAT=manylinux1_x86_64 -v `pwd`:/io quay.io/pypa/manylinux1_x86_64 /io/scripts/build-manylinux-wheels.sh

# The -e just defines an environment variable PLAT=[docker name] inside the Docker:
# auditwheel can't detect the Docker name automatically.
# $ docker run -v `pwd`:/io quay.io/pypa/manylinux1_x86_64 /io/scripts/build-manylinux-wheels.sh

# The -v gives a directory alias for passing files in and out of the Docker.
# (/io is arbitrary). E.g the setup.py script can be accessed in the Docker via
Expand Down Expand Up @@ -39,5 +36,5 @@ done
mkdir -p /io/dist/

for whl in /io/temp-wheels/*.whl; do
auditwheel repair "$whl" --plat $PLAT -w /io/dist/
auditwheel repair "$whl" -w /io/dist/
done

0 comments on commit 27b82c8

Please sign in to comment.