Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop WhiteNoise warning about STATIC_ROOT not existing during tests #1157

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Oct 4, 2018

Description of change

This is related to evansd/whitenoise#191, but that fix doesn't work as settings.DEBUG gets set to False when running tests.

This simply sets the two settings that are normally set from settings.DEBUG to True, which then triggers the fix in WhiteNoise. I don't expect any real effect on the tests as there wouldn't normally be requests for static files in them.

Checklist

  • Has a new newsfragment been created? Check changelog/README.rst for instructions
  • Have any relevant search models been updated?
  • Have any relevant fixtures (fixtures/test_data.yaml) been updated?
  • Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
  • Has the admin site been updated (for new models, fields etc.)?
  • Has the README been updated (if needed)?

@reupen reupen requested a review from marcofucci October 4, 2018 13:37
@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #1157 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1157   +/-   ##
========================================
  Coverage    96.58%   96.58%           
========================================
  Files          234      234           
  Lines         6539     6539           
  Branches       612      612           
========================================
  Hits          6316     6316           
  Misses         154      154           
  Partials        69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7331c...e197d1b. Read the comment docs.

@reupen reupen force-pushed the quieter-whitenoise-during-tests branch from f697e5e to e49c35b Compare October 4, 2018 14:24
@reupen reupen force-pushed the quieter-whitenoise-during-tests branch from e49c35b to e197d1b Compare October 4, 2018 14:43
@reupen reupen merged commit 829f803 into develop Oct 4, 2018
@reupen reupen deleted the quieter-whitenoise-during-tests branch October 4, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants