Only cluster pen micro clusters with more than one pen #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's exclude all the one off clusters. They are just too many and will not let me move ahead. I might look at those later on, but for now the ones with more than one assigned pen are more important. It seems like a better idea to improve the automated rules to group more of the pens anyway, that trying to do it all manually, too. Especially, as we're talking about 50-60k micro clusters.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2200 +/- ##
==========================================
+ Coverage 69.11% 69.12% +0.01%
==========================================
Files 253 253
Lines 4199 4201 +2
Branches 156 156
==========================================
+ Hits 2902 2904 +2
Misses 1281 1281
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's exclude all the one off clusters. They are just too many and will not let me move ahead. I might look at those later on, but for now the ones with more than one assigned pen are more important.
It seems like a better idea to improve the automated rules to group more of the pens anyway, that trying to do it all manually, too. Especially, as we're talking about 50-60k micro clusters.