Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic app components #2165

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Generic app components #2165

merged 4 commits into from
Apr 25, 2024

Conversation

ujh
Copy link
Owner

@ujh ujh commented Apr 25, 2024

Now only functions that do ink specific work are left in that folder. The rest of the structure is now generic and I can start building the pens clustering on top of it.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 70.91%. Comparing base (e8561d9) to head (32fa931).

Files Patch % Lines
...javascript/src/admin/components/clustering/App.jsx 0.00% 1 Missing ⚠️
...dmin/components/clustering/DisplayMicroCluster.jsx 0.00% 1 Missing ⚠️
app/javascript/src/admin/micro-clusters/index.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2165      +/-   ##
==========================================
- Coverage   72.57%   70.91%   -1.67%     
==========================================
  Files         247      246       -1     
  Lines        4025     4022       -3     
  Branches      157      157              
==========================================
- Hits         2921     2852      -69     
- Misses       1086     1154      +68     
+ Partials       18       16       -2     
Flag Coverage Δ
javascript 54.64% <0.00%> (-4.70%) ⬇️
ruby 79.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ujh ujh merged commit 37dfde4 into master Apr 25, 2024
5 of 7 checks passed
@ujh ujh deleted the generic-display-micro-cluster branch April 25, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant