fix: remove npm from install script #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `install` script will fail when using a package manager other than npm (such as yarn or pnpm) either through corepack or the scenario when npm is not installed at all.
|
I'm encountering this issue. Same situation as OP, corepack-enabled pnpm. Would love to see this merged. |
|
@uhop Can you take a look when you have a moment? Thanks! |
|
I want to release the latest three patches together. That's why a holdup. |
|
Published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
installscript will fail when using a package manager other than npm (such as yarn or pnpm) through corepack.It will also fail in the case when npm is not installed at all.
This change should also be a tiny bit faster since it invokes node-gyp directly instead of relying on npm to invoke it.