Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change registerPlugin to add plugin after Extensions plugins #658

Merged
merged 2 commits into from Apr 12, 2020
Merged

Change registerPlugin to add plugin after Extensions plugins #658

merged 2 commits into from Apr 12, 2020

Commits on Apr 8, 2020

  1. Change registerPlugin to add plugin after Extensions plugins 

    This commit changes `registerPlugin` by 1. adding the new plugin to `this.plugins` and 2. updating `this.plugins` within `this.state.plugins` by splicing with the new `this.plugins` length. Previously, new plugins were simply added to the end of `this.state.plugins` and were not appended to `this.plugins`. 

By placing new plugins at this new location within `this.state.plugins`, we prioritize registered plugins over default ProseMirror plugins such as `keymap(baseKeymap)`. This will allow new plugins to have precedence over props such as `handleKeyDown`.
    @BrianHung
    BrianHung committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    90f0498 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Updated registerPlugin and README with handlePlugins argument.

    @BrianHung
    BrianHung committed Apr 11, 2020
    Configuration menu
    Copy the full SHA
    f9d2986 View commit details
    Browse the repository at this point in the history