Allow camelcased deprecated lifecycle methods prepended with UNSAFE #57
Conversation
| camelcase: ['error', { properties: 'never' }], | ||
| camelcase: ['error', { | ||
| properties: 'never', | ||
| allow: ['UNSAFE_componentWillMount', 'UNSAFE_componentWillReceiveProps', 'UNSAFE_componentWillUpdate'], |
There was a problem hiding this comment.
Let's definitely create a follow-up task to get rid of these UNSAFE_ usages and delete this configuration eventually.
There was a problem hiding this comment.
Sure. Do you think it would be better to just copy this configuration over to the .eslintrc file in the website-django codebase and delete it once we fully deprecate those methods?
There was a problem hiding this comment.
I'm okay either way. Since you're doing Team F work, feel free to create a card on our board as Cansin asked.
| @@ -10,7 +10,10 @@ module.exports = { | |||
| // enforce one true brace style | |||
There was a problem hiding this comment.
Remember that it's really important to write your commit messages in the right format since they automatically control the versioning and the CHANGELOG. See the bottom of https://github.com/udemy/js-tooling. You may want to rebase and change how you worded your commit message.
| camelcase: ['error', { properties: 'never' }], | ||
| camelcase: ['error', { | ||
| properties: 'never', | ||
| allow: ['UNSAFE_componentWillMount', 'UNSAFE_componentWillReceiveProps', 'UNSAFE_componentWillUpdate'], |
There was a problem hiding this comment.
I'm okay either way. Since you're doing Team F work, feel free to create a card on our board as Cansin asked.
|
Closing this as per the discussion mentioned here: https://github.com/udemy/website-django/pull/31054#discussion_r244208432 Since this is a temporary rule, we want to override it in the |
To:
@udemy/team-f
What:
In order to upgrade React past version 16.3, the react/no-unsafe eslint rule must be satisfied.
However, that rule conflicts with camelcase without providing the
allowoption to the rule.This PR configures the camelcase rule to allow certain
UNSAFE_prefixed deprecated React component lifecycle methods to be exempt.Reference: eslint/eslint#10783
React 16.7 Upgrade PR: https://github.com/udemy/website-django/pull/31054
JIRA:
What did you test:
<Any manual testing you've done in addition to the automated tests>
What dashboards will you be monitoring: