Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 dep: update codecov-action #3356

Merged
merged 1 commit into from Jun 10, 2021
Merged

📦 dep: update codecov-action #3356

merged 1 commit into from Jun 10, 2021

Conversation

hueyy
Copy link
Contributor

@hueyy hueyy commented Jun 10, 2021

What does this PR do?

As the title says. This should resolve the codecov upload failure (codecov/codecov-action#330)

✅ Pull Request checklist

  • Is this code complete?
  • Are tests done/modified?
  • Are docs written for this PR? (if applicable)

🚨 Is this a breaking change for API clients?

No

@hueyy hueyy requested a review from a team June 10, 2021 15:08
@hueyy hueyy self-assigned this Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #3356 (e180c0c) into master (22f571f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3356   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files          85       85           
  Lines        7398     7398           
=======================================
  Hits         5950     5950           
  Misses       1448     1448           

@greenfrogs
Copy link
Contributor

I was looking through the CodeCov email and trying to check if the github action verifies bth the key signature and the checksum. I could not seem to find it though.

@hueyy
Copy link
Contributor Author

hueyy commented Jun 10, 2021

Verifies the key signature and the checksum of the bash uploader? Doesn't look like. It appears the bash script is part of the source code for the GitHub Action and is manually updated: https://github.com/codecov/codecov-action/blob/master/src/codecov

@hueyy hueyy merged commit 116340f into master Jun 10, 2021
@hueyy hueyy deleted the feature/codecov_update branch June 10, 2021 15:36
@hueyy hueyy temporarily deployed to Staging June 10, 2021 15:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants