CLI QOL; docs update #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
point-of-contact, update of CLI.
krashanoff
added
bug
timothycpoon
approved these changes
May 13, 2021
|
I'll leave this open until midnight tonight. I removed the code that kills the program if a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short PR to address a few issues that new members were encountering during onboarding to the backend:
.envwere improperly parsed. To address this, we have temporarily switched ourgodotenvto x1unix's fork. For further reading on the issue and why we are using a fork rather than waiting for the changes to be merged, see Doesn't support multiline vars joho/godotenv#64 and Add multi-line values support joho/godotenv#118..envfiles because our key names were inconsistent. Addressed this by matching them. See server.go#L43 and L128..envoptions take precedence over CLI options. This should be the default, since most of our developers are simply running./bin/tlabe. These changes appear in server.go#L88:93Before this PR is ready for review, I plan on also updating our
README.mdto reflect the new project structure.