Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ease of use fixes #116

Merged
merged 10 commits into from May 20, 2024
Merged

Ease of use fixes #116

merged 10 commits into from May 20, 2024

Conversation

cayb0rg
Copy link
Collaborator

@cayb0rg cayb0rg commented Apr 16, 2024 •
edited

  • Can change port now
  • Can change NODE_ENV now
  • Redirects old routes to the new ones
  • Adds an example webpack config for widgets that I will link in Wiki
  • Fixes some loaders (specifically the React and images one)
  • Adds link to Contributing section to README

@cayb0rg cayb0rg marked this pull request as ready for review April 17, 2024 14:09
clpetersonucf
clpetersonucf approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to be working, I think this is good.

FrenjaminBanklin
FrenjaminBanklin approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like everything is working well, functionally.

I haven't really tried every widget exhaustively, but given the extensibility of the loaders etc. this seems like it's fine as-is.

@clpetersonucf clpetersonucf merged commit 6a35591 into ucfopen:master May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clpetersonucf clpetersonucf clpetersonucf approved these changes

@FrenjaminBanklin FrenjaminBanklin FrenjaminBanklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cayb0rg @clpetersonucf @FrenjaminBanklin