Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors earlier #101

Closed
wants to merge 1 commit into from
Closed

Log errors earlier #101

wants to merge 1 commit into from

Conversation

paulineribeyre
Copy link
Contributor

Improvements

  • Log download-multiple errors earlier, in addition to logging all errors at the end

@paulineribeyre
Copy link
Contributor Author

@mfshao:

you can only do prints BEFORE the pb pool has started. This is an limitation of cheggaaa/pb https://github.com/cheggaaa/pb/blob/master/README_V1.md#multiple-progress-bars-experimental-and-unstable that you really cannot print to terminal when the pb pool is activated.
And I don’t think this is doable even in the latest V3 of cheggaaa/pb because cheggaaa/pb#110 is still open.
and this is the intention why for the sections that has pb pool involved, we only send printouts to a channel and print them all after we are done with progress bars.
maybe this is an better option https://github.com/vbauerster/mpb but need some effort to replace and test.

@paulineribeyre paulineribeyre deleted the err-logs branch October 20, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant