Variable Inline Fixes: Reorder and Add Tests #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some variable inline issues observed when the tooling was used to produce diffs. Also adds new tests to ensure correctness. Please refer to tests to understand the scenarios better.
Reason for reordering: It seems that
replace_identifier_with_valuewas getting executed beforereplace_self_identifier_with_value. One of the constraints ofreplace_identifier_with_valueis to not replace the variable if it used in self expression (self.x) manner due to which it wasn't getting executed at all. Changing the order seems to have solved this without breaking anything.