Resolve logging problem #231
Conversation
ketkarameya
changed the base branch from
master
to
feature/simple_python_bindings
…ls and cleanup println!s .
ketkarameya
force-pushed
the
bugfix/logging
branch
from
3a26031
to
74a2887
Compare
There was a problem hiding this comment.
Minor nits about imports, but overall I am fine with this change.
Question: when you say you can't output logs in color to a file, do you mean that if you add calls like .green() the logs aren't written at all when sent to a file? Because if you just mean the color is lost, then I'd expect that from the fact that it's a plain test file and not a rich TTY.
| @@ -14,7 +14,7 @@ Copyright (c) 2022 Uber Technologies, Inc. | |||
| use std::collections::HashMap; | |||
|
|
|||
| use colored::Colorize; | |||
| use log::info; | |||
| use log::{info}; | |||
There was a problem hiding this comment.
Needed? I think log::info is the right syntax if we are just importing that, no?
There was a problem hiding this comment.
YEs. Addressed by cargo format.
I think I ll add a new Github action that runs cargo format on each PR, as a commit. Idk
polyglot/piranha/src/tests/mod.rs
Outdated
| @@ -13,11 +13,13 @@ Copyright (c) 2022 Uber Technologies, Inc. | |||
|
|
|||
| use std::path::{Path, PathBuf}; | |||
|
|
|||
| use log::{error}; | |||
| @@ -19,7 +19,7 @@ use crate::{ | |||
| }; | |||
| use colored::Colorize; | |||
| use itertools::Itertools; | |||
| use log::info; | |||
| use log::{info}; | |||
There was a problem hiding this comment.
Am I missing something about log::{info} vs log::info
There was a problem hiding this comment.
No its equivalent.
I think during my changes I had added a warn macro in this file and made this import ->
log::info -> log::{info, warn}. But then I removed warn, and {} remained. I will clean i up.
Hmmm Its actually that the characters don't get encoded and are shown as blobs :| . It is open issue (rust-cli/env_logger#208 and rust-cli/env_logger#178) it has something to do with the |
So since a long time, our logs were not getting printed properly :| I tried a lot hacks and work arounds but for some reason I am unable to have the logs written to a particular log file with color and has some encoding issue :-| Now there are some work arounds mentioned in the issues : 1 and 2, but it doesn't work for me :-| . Now we either use some other library (apparently the one we are using is most popular) or we just
catwhen we want logs to be written to a particular file.I also cleaned up the logs -
(i) removed unnecessary logs
(ii)
println->info