Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes classification error for deprecated domains #6016

Conversation

davidporter-id-au
Copy link
Contributor

@davidporter-id-au davidporter-id-au commented May 12, 2024

What changed?

This fixes errors being classified as server errors (HTTP 5XX errors) when a domain is deprecated and correctly reclassifies them as application/ 4XX errors

Why?

How did you test it?
Screenshot 2024-05-11 at 9 56 41 PM

Potential risks

Release notes

Documentation Changes

@davidporter-id-au davidporter-id-au changed the title maybe fix errro Fixes classification error for deprecated domains May 12, 2024
@davidporter-id-au davidporter-id-au marked this pull request as ready for review May 12, 2024 04:57
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.88%. Comparing base (8821ae9) to head (e3916b0).
Report is 1 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
...ice/frontend/wrappers/clusterredirection/policy.go 75.00% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8821ae9...e3916b0. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f6b27-7cfd-4b8f-a353-aab36e9388e4

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 36 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.03%) to 69.189%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
common/task/parallel_task_processor.go 2 93.06%
service/frontend/api/handler.go 2 62.32%
service/history/replication/task_processor.go 2 81.25%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/historyManager.go 2 66.67%
common/persistence/statsComputer.go 3 96.79%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/history/execution/context_util.go 8 83.21%
service/frontend/wrappers/metered/metered.go 9 63.18%
Totals Coverage Status
Change from base Build 018f6b25-dc8e-4324-83db-b2d258902457: 0.03%
Covered Lines: 101656
Relevant Lines: 146926

💛 - Coveralls

@davidporter-id-au davidporter-id-au enabled auto-merge (squash) May 12, 2024 17:47
@davidporter-id-au davidporter-id-au merged commit 3c59510 into uber:master May 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants