Refactor matching and split the files into subpackages #6000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
force-pushed
the
matching
branch
3 times, most recently
from
706bfd8
to
070ad7a
Compare
Pull Request Test Coverage Report for Build 018f5f66-582f-4a02-8ecc-259a2c7f45b8Details
💛 - Coveralls |
| @@ -138,19 +153,26 @@ const ( | |||
| maxSyncMatchWaitTime = 200 * time.Millisecond | |||
| ) | |||
|
|
|||
| var _ taskListManager = (*taskListManagerImpl)(nil) | |||
| var _ Manager = (*taskListManagerImpl)(nil) | |||
There was a problem hiding this comment.
nit: this is not needed
taylanisikdemir
approved these changes
May 10, 2024
| } | ||
| activityTaskListMap[tl.baseName] = tlm.DescribeTaskList(false) | ||
| // TODO: review this logic |
There was a problem hiding this comment.
mind putting in the comment what seems off?
| dPtr := _defaultTaskDispatchRPS | ||
| limiter := quotas.NewRateLimiter(&dPtr, _defaultTaskDispatchRPSTTL, config.MinTaskThrottlingBurstSize()) | ||
| func newTaskMatcher(config *config.TaskListConfig, fwdr *Forwarder, scope metrics.Scope, isolationGroups []string, log log.Logger) *TaskMatcher { | ||
| dPtr := config.TaskDispatchRPS |
There was a problem hiding this comment.
Is this what you were referring to as having to be pulled into a central location?
There was a problem hiding this comment.
the central location of the default values is config/config.go
davidporter-id-au
approved these changes
May 11, 2024
abhishekj720
pushed a commit
to abhishekj720/cadence
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor matching and split the files into subpackages
Why?
To improve the quality of the codebase
How did you test it?
existing unit tests
Potential risks
The risk is a bit high because it changes almost everything inside matching packages by splitting the files into subpackages. We need at 2 pairs of eyes for reviewing this PR.
Release notes
Documentation Changes