Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for starting, stopping and purging daemon for replicationQueue #5973

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Added tests for starting, stopping and purging daemon for replicationQueue #5973

wants to merge 15 commits into from

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added tests for replicationQueue present in common domain

Why?
As part of test coverage week

How did you test it?
Unit tests

Potential risks
No risks. Added to avoid risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.68%. Comparing base (17a7ba7) to head (4825cd9).
Report is 7 commits behind head on master.

Additional details and impacted files

see 10 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a7ba7...4825cd9. Read the comment docs.

taylanisikdemir and others added 9 commits May 7, 2024 14:23
@taylanisikdemir @abhishekj720
Replace wurstmeister kafka/zookeeper images with bitnami kafka image (u…
d0e586c 
…ber#5975)
@taylanisikdemir @abhishekj720
Split historyEngine.go into small files (uber#5972)
0efab43
@timl3136 @abhishekj720
Added unit tests for service/history/handler (uber#5970)
dedc023 
* Added unit tests for history handler
@Shaddoll @abhishekj720
Add unit tests for mutable state task refresher (uber#5971)
b28766e
@taylanisikdemir @abhishekj720
Revert codecov patch threshold to 85% (uber#5982)
d45186d
@ibarrajo @abhishekj720
Api handler test respond activity task failed alternate (uber#5980)
c21a71a 
* TestRespondActivityTaskFailed_Success implementation

* Alternate test for TerstRespondActivityTaskFailed

* code lint
@natemort @abhishekj720
Move shardscanner workflow tests to the shardscanner package (uber#5981)
7eed1c1 
This ensures they get included in the code coverage metrics.
@abhishekj720
Change after review
1e8c374
@abhishekj720
Merge branch 'uber:master' into crq1
6374678
@coveralls
Copy link

coveralls commented May 7, 2024 •
edited

Pull Request Test Coverage Report for Build 018f56cb-b80d-44f0-ae5b-75535fef3d83

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 54 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.02%) to 68.431%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/queue/timer_queue_processor_base.go 1 78.28%
service/matching/taskReader.go 2 84.88%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/task/parallel_task_processor.go 2 93.06%
service/history/execution/mutable_state_util.go 2 78.52%
service/history/task/task.go 3 84.81%
service/history/task/timer_standby_task_executor.go 3 85.63%
service/history/task/timer_active_task_executor.go 3 79.33%
service/matching/taskListManager.go 4 80.65%
Totals Coverage Status
Change from base Build 018f54e5-7508-40f1-ae99-a0884c40b0fa: 0.02%
Covered Lines: 100511
Relevant Lines: 146880
💛 - Coveralls

taylanisikdemir
taylanisikdemir reviewed May 8, 2024
View reviewed changes
common/domain/replication_queue_test.go
close(done)
}()

rq.Stop()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rq.Stop() would be called before rq.Start() inside goroutine.

What exactly are you trying to validate in this function that is not covered by Start/Stop? Expecting purgeAckedMessages() is called once would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groxx Groxx Groxx left review comments

@taylanisikdemir taylanisikdemir taylanisikdemir left review comments

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@agautam478 agautam478 Awaiting requested review from agautam478 agautam478 is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@abhishekj720 @coveralls @Groxx @taylanisikdemir @timl3136 @Shaddoll @ibarrajo @natemort