Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test for dynamicconfig/configstore/config_store_client.go #5900

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

d-vignesh
Copy link
Contributor

@d-vignesh d-vignesh commented Apr 10, 2024

What changed?
Added test for uncovered lines in dynamicconfig/configstore/config_store_client.go

Why?
To improve code coverage

How did you test it?
locally using go test

Potential risks
NA

Release notes

Documentation Changes

@d-vignesh d-vignesh changed the title added test for uncovered lines in dynamicconfig/configstore/co… [DRAFT] added test for uncovered lines in dynamicconfig/configstore/co… Apr 10, 2024
@d-vignesh d-vignesh changed the title [DRAFT] added test for uncovered lines in dynamicconfig/configstore/co… added test for uncovered lines in dynamicconfig/configstore/co… Apr 16, 2024
@taylanisikdemir taylanisikdemir changed the title added test for uncovered lines in dynamicconfig/configstore/co… added test for dynamicconfig/configstore/config_store_client.go Apr 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018ee790-5061-42cf-96e2-3de5be2afab7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1228 unchanged lines in 22 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.407%

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/persistence/nosql/nosqlplugin/types.go 2 60.0%
service/matching/taskReader.go 2 84.88%
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/task/fetcher.go 3 85.57%
common/persistence/nosql/nosql_task_store.go 5 61.95%
common/task/fifo_task_scheduler.go 5 84.54%
service/history/task/transfer_standby_task_executor.go 6 86.19%
common/persistence/data_manager_interfaces.go 8 96.51%
common/persistence/nosql/nosqlplugin/errors.go 12 0.0%
Totals Coverage Status
Change from base Build 018ee46d-6495-47ba-900b-2030e24c5f31: 0.03%
Covered Lines: 98263
Relevant Lines: 145776

💛 - Coveralls

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.65%. Comparing base (6d8466c) to head (6c8f6b2).
Report is 64 commits behind head on master.

Additional details and impacted files

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8466c...6c8f6b2. Read the comment docs.

tests := []struct {
desc string
input *c.ClientConfig
checkForError bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: checkForError could be renamed to wantErr. same below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed the field

@agautam478 agautam478 enabled auto-merge (squash) May 7, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants