-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added test for dynamicconfig/configstore/config_store_client.go #5900
base: master
Are you sure you want to change the base?
added test for dynamicconfig/configstore/config_store_client.go #5900
Conversation
…nfig_store_client.go
Pull Request Test Coverage Report for Build 018ee790-5061-42cf-96e2-3de5be2afab7Details
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
tests := []struct { | ||
desc string | ||
input *c.ClientConfig | ||
checkForError bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: checkForError
could be renamed to wantErr
. same below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed the field
What changed?
Added test for uncovered lines in dynamicconfig/configstore/config_store_client.go
Why?
To improve code coverage
How did you test it?
locally using go test
Potential risks
NA
Release notes
Documentation Changes