Addition of test for TestHandler_UpdateAsyncWorkflowConfiguration #5892
Conversation
abhishekj720
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018ec380-10d8-45b7-aa82-c2cd1d358cd6Details
💛 - Coveralls |
Codecov Report
Additional details and impacted filessee 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| expectedErr error | ||
| }{ | ||
| { | ||
| name: "fail to get metadata", |
There was a problem hiding this comment.
not a real problem, but just a tip: Genuinely starting with the success case is a bit easier because you typically have to construct the most mocks and return results. And thereafter all the error cases are typically just subsets of the first entry. It just makes copying + pasting easier
| LastUpdatedTime: time.Now().Add(-24 * time.Hour).UnixNano(), | ||
| }, nil) | ||
|
|
||
| mockDomainManager.EXPECT().UpdateDomain(gomock.Any(), gomock.Any()).Return(nil) |
There was a problem hiding this comment.
Sorry to be annoying, but if the test is to really have any serious value at all the updateDomain request should be specified here. Just doing gomock.Any() doesn't really tell you much if anything's broken
What changed?
Test for UpdateAsyncWorkflowConfiguraton
Why?
As part of code coverage week
How did you test it?
Unit test
Potential risks
No risk