Addition of tests for HandleDomainCreationReplicationTask in replicationTaskExecutor #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekj720
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
* Add unit tests for open search client * Simplify tests in v6 and v7 client
Codecov Report
Additional details and impacted filessee 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018e3132-d2aa-4462-8ae2-83fa64f1aa63Details
💛 - Coveralls |
3vilhamster
reviewed
Mar 12, 2024
| t.Run(tt.name, func(t *testing.T) { | ||
| ctrl := gomock.NewController(t) | ||
| mockDomainManager := persistence.NewMockDomainManager(ctrl) | ||
| mockLogger := log.NewNoop() |
| ctrl := gomock.NewController(t) | ||
| mockDomainManager := persistence.NewMockDomainManager(ctrl) | ||
| mockLogger := log.NewNoop() | ||
| mockTimeSource := clock.NewRealTimeSource() |
There was a problem hiding this comment.
nit: clock.NewMockedTimeSourceAt with a fixed time.
| Return(nil, errors.New("unexpected error")).Times(1) // Simulate an unexpected error from GetDomain | ||
| }, | ||
| task: &types.DomainTaskAttributes{ | ||
| DomainOperation: types.DomainOperationCreate.Ptr(), |
There was a problem hiding this comment.
I suggest refactoring out test data from here. It is very hard to read the test cases that are over 200 lines with intendation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added tests in common/domain folder for HandleDomainCreationReplicationTask in replicationTaskExecutor go file
Why?
to increase code coverage
How did you test it?
Unit Tests
Potential risks
No risks, as it only involves tests with mocking behaviors.