Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for null pointer exception in case header getFields is null #888

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added a fix for the case when headers's getFields is null.
Causing null pointer in the code.

Why?
Bug fix

How did you test it?
Need to add test for it. will discuss with the team, now adding this to fix bug and unblock customer.

Potential risks
It should be a safe change, as it is returning empty map in case of empty getFields.

Release notes

Documentation Changes

@Groxx
Copy link
Contributor

Groxx commented May 3, 2024

Yea - makes sense and looks safe to me.

Is this user-controlled / just optional in general so nulls are obviously possible, or is there code somewhere that should be populating this? Now's a good time to go hunting if it's unknown, since this'll basically be hiding the flaw for who knows how long if it actually is a flaw.

(it does seem pretty likely that this is just optional / user controlled though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants