Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap data converter exception in activity failure exception #334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meiliang86
Copy link
Contributor

Currently only adding activity type. ActivityId and EventId is not available right now in SyncDecisionContext and it's not trivial to add. My understanding is that activity type should be good enough for trouble shooting purpose. Open to discussions though.

@meiliang86 meiliang86 requested a review from mfateev July 8, 2019 18:30
@meiliang86 meiliang86 added this to the Sprint 6/24 - 7/3 milestone Jul 8, 2019
Copy link
Collaborator

@mfateev mfateev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit test

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Liang Mei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants