Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete OptionalEmptinessHandler method that is no longer needed #954

Merged
merged 2 commits into from May 14, 2024

Conversation

msridhar
Copy link
Collaborator

Fixes #953

@msridhar msridhar enabled auto-merge (squash) April 30, 2024 03:07
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.11%. Comparing base (a017158) to head (e02bbd3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #954      +/-   ##
============================================
+ Coverage     86.06%   86.11%   +0.04%     
+ Complexity     2032     2030       -2     
============================================
  Files            81       81              
  Lines          6669     6662       -7     
  Branches       1294     1291       -3     
============================================
- Hits           5740     5737       -3     
+ Misses          516      512       -4     
  Partials        413      413              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msridhar msridhar merged commit c26ae17 into uber:master May 14, 2024
12 checks passed
@msridhar msridhar deleted the issue-953 branch May 14, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OptionalEmptinessHandler method for propagating access paths to lambdas
2 participants