Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename test classes #951

Merged
merged 3 commits into from Apr 22, 2024
Merged

Rename test classes #951

merged 3 commits into from Apr 22, 2024

Conversation

msridhar
Copy link
Collaborator

This is a pure refactoring PR that only touches test code and does the following:

  • Renames test classes to remove the NullAway prefix, which hinders readability
  • Moves JSpecify tests into their own package
  • Remove nullaway/src/test/java/com/uber/nullaway/NullAwayTypeUseAnnotationTests.java and move its one test into nullaway/src/test/java/com/uber/nullaway/TypeUseAnnotationsTests.java (this must have been a typo before)

@msridhar msridhar requested a review from yuxincs April 22, 2024 17:44
@msridhar msridhar enabled auto-merge (squash) April 22, 2024 17:58
yuxincs
yuxincs approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

@msridhar msridhar merged commit 719b167 into uber:master Apr 22, 2024
10 checks passed
@msridhar msridhar deleted the rename-test-classes branch April 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxincs yuxincs yuxincs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msridhar @yuxincs