Remove URI serialization for classes coming from .class files from fix serialization code #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
approved these changes
Mar 25, 2023
There was a problem hiding this comment.
This LGTM but @lazaroclapp you should probably take a quick look in case I missed something
|
Going to land this as it looks pretty safe. We can revert if some issue is spotted |
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit abac2ae.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 18, 2023
This reverts commit abac2ae.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit abac2ae.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit abac2ae.
msridhar
added a commit
to msridhar/NullAway
that referenced
this pull request
Jul 19, 2023
This reverts commit abac2ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially resolves #716 by removing URI serialization for classes coming from
.classfiles in all serializations.In Annotator all serialized paths in downstream dependencies analysis phase, are neglected and retrieved from internal data structure of Annotator. Please see Github
I tested Annotator with a local snapshot of NullAway with latest changes in this PR and I did not see any problem.
#716 is partially resolved since it requires updating path constructions in tests as well, which I will work on it on a separate PR.