Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved varargs support. #291

Merged
merged 3 commits into from Mar 29, 2019
Merged

Improved varargs support. #291

merged 3 commits into from Mar 29, 2019

Commits on Mar 29, 2019

  1. Improved varargs support. 

    Resolves #290 by supporting vararg nullability.

Previously, we ignored the default nullability info of vararg arguments,
but would error out if the vararg formal was deemed non-null by a handler.

Instead, we now correctly acknowledge the nullability of vararg arguments
whether they are non-null due to default code assumptions or due to handlers
(restrictive annotations, `@Contract`, etc).

This PR also adds tests and support for `javax.annotations.Nonnull` which
we were ignoring before and is needed for those tests.
    @lazaroclapp
    lazaroclapp committed Mar 29, 2019
    Copy the full SHA
    0ce91c0 View commit details
    Browse the repository at this point in the history

  2. Warn about unsupported @nullable var args case.

    @lazaroclapp
    lazaroclapp committed Mar 29, 2019
    Copy the full SHA
    c76e6f5 View commit details
    Browse the repository at this point in the history

  3. Rebase and fix error message dispatch

    @lazaroclapp
    lazaroclapp committed Mar 29, 2019
    Copy the full SHA
    fee2c25 View commit details
    Browse the repository at this point in the history