Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for generating @SuppressWarnings #271

Merged
merged 4 commits into from Dec 13, 2018
Merged

Various fixes for generating @SuppressWarnings #271

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3adc98a
Suppress properly for deref on RHS of field initializer
msridhar Dec 12, 2018
3fac3f1
handle unboxing
msridhar Dec 12, 2018
42b19b9
more fixes
msridhar Dec 12, 2018
fa2d13f
another test
msridhar Dec 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 40 additions & 0 deletions nullaway/src/test/java/com/uber/nullaway/NullAwayAutoSuggestNoCastTest.java
View file
Open in desktop
Expand Up @@ -209,6 +209,46 @@ public void suggestSuppressionFieldLambdaAssignment() {
bcr.doTest(BugCheckerRefactoringTestHelper.TestMode.TEXT_MATCH);
}

@Test
public void suggestLambdaAssignInMethod() {
BugCheckerRefactoringTestHelper bcr =
BugCheckerRefactoringTestHelper.newInstance(
new NullAway(flagsNoAutoFixSuppressionComment), getClass());

bcr.setArgs("-d", temporaryFolder.getRoot().getAbsolutePath());
bcr.addInputLines(
"Test.java",
"package com.uber;",
"import javax.annotation.Nullable;",
"class Test {",
" @Nullable private Integer foo;",
" @Nullable private java.util.function.Function<Object, Integer> f;",
" void m1() {",
" f = (x) -> { return foo + 1; };",
" }",
" void m2() {",
" java.util.function.Function<Object,Integer> g = (x) -> { return foo + 1; };",
" }",
"}")
.addOutputLines(
"out/Test.java",
"package com.uber;",
"import javax.annotation.Nullable;",
"class Test {",
" @Nullable private Integer foo;",
" @Nullable private java.util.function.Function<Object, Integer> f;",
" @SuppressWarnings(\"NullAway\")",
" void m1() {",
" f = (x) -> { return foo + 1; };",
" }",
" void m2() {",
" @SuppressWarnings(\"NullAway\")",
" java.util.function.Function<Object,Integer> g = (x) -> { return foo + 1; };",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

" }",
"}");
bcr.doTest(BugCheckerRefactoringTestHelper.TestMode.TEXT_MATCH);
}

@Test
public void suppressMethodRefOverrideParam() {
BugCheckerRefactoringTestHelper bcr =
Expand Down