Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zapcore: add stopped for Stop method called exactly once #966

Merged
merged 4 commits into from Jun 24, 2021
Merged

zapcore: add stopped for Stop method called exactly once #966

merged 4 commits into from Jun 24, 2021
+24 −4

Commits on Jun 16, 2021

  1. zapcore: add stopOnce for Stop method called exactly once 

    name                                           old time/op    new time/op    delta
BufferedWriteSyncer/write_file_with_buffer-20     137ns ± 1%     139ns ± 2%    ~     (p=0.082 n=5+6)
MultiWriteSyncer/2_discarder-20                  8.05ns ± 6%    7.93ns ± 2%    ~     (p=0.662 n=6+5)
MultiWriteSyncer/4_discarder-20                  9.15ns ± 4%    9.14ns ± 4%    ~     (p=1.000 n=5+5)
MultiWriteSyncer/4_discarder_with_buffer-20       131ns ± 2%     130ns ± 0%    ~     (p=0.370 n=6+6)
WriteSyncer/write_file_with_no_buffer-20         4.36µs ± 1%    4.24µs ± 2%  -2.96%  (p=0.004 n=5+6)
ZapConsole-20                                     787ns ± 1%     800ns ± 2%    ~     (p=0.052 n=5+6)
JSONLogMarshalerFunc-20                           738ns ± 1%     737ns ± 0%    ~     (p=0.970 n=6+6)
ZapJSON-20                                        586ns ± 4%     582ns ± 3%    ~     (p=0.818 n=6+6)
StandardJSON-20                                   991ns ± 9%     977ns ± 2%    ~     (p=0.892 n=6+5)
Sampler_Check/7_keys-20                          8.58ns ± 3%    8.49ns ± 2%    ~     (p=0.485 n=6+6)
Sampler_Check/50_keys-20                         8.18ns ± 1%    8.20ns ± 1%    ~     (p=0.690 n=5+5)
Sampler_Check/100_keys-20                        8.02ns ± 4%    8.02ns ± 2%    ~     (p=0.589 n=6+6)
Sampler_CheckWithHook/7_keys-20                  23.4ns ± 2%    23.2ns ± 2%    ~     (p=0.370 n=6+6)
Sampler_CheckWithHook/50_keys-20                 24.3ns ± 3%    24.8ns ± 7%    ~     (p=0.732 n=6+6)
Sampler_CheckWithHook/100_keys-20                24.1ns ± 2%    24.2ns ± 1%    ~     (p=0.662 n=5+6)
TeeCheck-20                                       118ns ± 1%     120ns ± 5%    ~     (p=1.000 n=4+6)
[Geo mean]                                       77.7ns         77.6ns       -0.08%

name                                           old alloc/op   new alloc/op   delta
BufferedWriteSyncer/write_file_with_buffer-20     16.0B ± 0%     16.0B ± 0%    ~     (all equal)
MultiWriteSyncer/2_discarder-20                   16.0B ± 0%     16.0B ± 0%    ~     (all equal)
MultiWriteSyncer/4_discarder-20                   16.0B ± 0%     16.0B ± 0%    ~     (all equal)
MultiWriteSyncer/4_discarder_with_buffer-20       16.0B ± 0%     16.0B ± 0%    ~     (all equal)
WriteSyncer/write_file_with_no_buffer-20          16.0B ± 0%     16.0B ± 0%    ~     (all equal)
ZapConsole-20                                    1.36kB ± 0%    1.36kB ± 0%    ~     (all equal)
JSONLogMarshalerFunc-20                          1.31kB ± 0%    1.31kB ± 0%    ~     (all equal)
ZapJSON-20                                       1.25kB ± 0%    1.25kB ± 0%    ~     (all equal)
StandardJSON-20                                  1.45kB ± 0%    1.45kB ± 0%    ~     (all equal)
Sampler_Check/7_keys-20                           0.00B          0.00B         ~     (all equal)
Sampler_Check/50_keys-20                          0.00B          0.00B         ~     (all equal)
Sampler_Check/100_keys-20                         0.00B          0.00B         ~     (all equal)
Sampler_CheckWithHook/7_keys-20                   0.00B          0.00B         ~     (all equal)
Sampler_CheckWithHook/50_keys-20                  0.00B          0.00B         ~     (all equal)
Sampler_CheckWithHook/100_keys-20                 0.00B          0.00B         ~     (all equal)
TeeCheck-20                                       64.0B ± 0%     64.0B ± 0%    ~     (all equal)
[Geo mean]                                         108B           108B       +0.00%

name                                           old allocs/op  new allocs/op  delta
BufferedWriteSyncer/write_file_with_buffer-20      1.00 ± 0%      1.00 ± 0%    ~     (all equal)
MultiWriteSyncer/2_discarder-20                    1.00 ± 0%      1.00 ± 0%    ~     (all equal)
MultiWriteSyncer/4_discarder-20                    1.00 ± 0%      1.00 ± 0%    ~     (all equal)
MultiWriteSyncer/4_discarder_with_buffer-20        1.00 ± 0%      1.00 ± 0%    ~     (all equal)
WriteSyncer/write_file_with_no_buffer-20           1.00 ± 0%      1.00 ± 0%    ~     (all equal)
ZapConsole-20                                      7.00 ± 0%      7.00 ± 0%    ~     (all equal)
JSONLogMarshalerFunc-20                            5.00 ± 0%      5.00 ± 0%    ~     (all equal)
ZapJSON-20                                         3.00 ± 0%      3.00 ± 0%    ~     (all equal)
StandardJSON-20                                    27.0 ± 0%      27.0 ± 0%    ~     (all equal)
Sampler_Check/7_keys-20                            0.00           0.00         ~     (all equal)
Sampler_Check/50_keys-20                           0.00           0.00         ~     (all equal)
Sampler_Check/100_keys-20                          0.00           0.00         ~     (all equal)
Sampler_CheckWithHook/7_keys-20                    0.00           0.00         ~     (all equal)
Sampler_CheckWithHook/50_keys-20                   0.00           0.00         ~     (all equal)
Sampler_CheckWithHook/100_keys-20                  0.00           0.00         ~     (all equal)
TeeCheck-20                                        1.00 ± 0%      1.00 ± 0%    ~     (all equal)
[Geo mean]                                         2.21           2.21       +0.00%

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
    @zchee
    zchee committed Jun 16, 2021
    Copy the full SHA
    72d9db1 View commit details
    Browse the repository at this point in the history

  2. zapcore: add called Stop twice testcase 

    Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
    @zchee
    zchee committed Jun 16, 2021
    Copy the full SHA
    69b22fd View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. zapcore: change stopOnce to stopped and add stopped local valua to mutex 

    Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
    @zchee
    zchee committed Jun 19, 2021
    Copy the full SHA
    2f946bb View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Update zapcore/buffered_write_syncer.go

    @prashantv
    prashantv committed Jun 24, 2021
    Copy the full SHA
    dedda5e View commit details
    Browse the repository at this point in the history