Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NewTicker to the Clock Interface #948

Merged
merged 9 commits into from May 25, 2021
Merged

Add NewTicker to the Clock Interface #948

merged 9 commits into from May 25, 2021

Commits on May 21, 2021

  1. Add NewTicker to Clock Interface

    @moisesvega
    moisesvega committed May 21, 2021
    Configuration menu
    Copy the full SHA
    96bbcb2 View commit details
    Browse the repository at this point in the history

  2. Update clock.go and use alias for Clock 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @moisesvega @abhinav
    moisesvega and abhinav committed May 21, 2021
    Configuration menu
    Copy the full SHA
    e330309 View commit details
    Browse the repository at this point in the history

  3. Add test to show case how with the new method can control the clock

    @moisesvega
    moisesvega committed May 21, 2021
    Configuration menu
    Copy the full SHA
    3ff020f View commit details
    Browse the repository at this point in the history

  4. Fix goroutine leak and simplify controlledClock

    @moisesvega
    moisesvega committed May 21, 2021
    Configuration menu
    Copy the full SHA
    f6c323d View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Create a second channel to indicate the goroutine has finished and ad… 

    …d leak_test.go
    @moisesvega
    moisesvega committed May 24, 2021
    Configuration menu
    Copy the full SHA
    c5c571c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Add Copyright to leak_test.go

    @moisesvega
    moisesvega committed May 25, 2021
    Configuration menu
    Copy the full SHA
    8db5f86 View commit details
    Browse the repository at this point in the history

  2. Update zapcore/clock.go 

    Use double quotes in comments.

Co-authored-by: Minho Park <minho.park@uber.com>
    @moisesvega @mh-park
    moisesvega and mh-park committed May 25, 2021
    Configuration menu
    Copy the full SHA
    b5b0876 View commit details
    Browse the repository at this point in the history

  3. Increased coverage by using _systemClock.NewTicker

    @moisesvega
    moisesvega committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7c2d864 View commit details
    Browse the repository at this point in the history

  4. simplify system clock test

    @abhinav
    abhinav committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0839a6b View commit details
    Browse the repository at this point in the history