Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consoleEncoder: put cloned jsonEncoder back to pool #852

Merged
merged 2 commits into from Aug 5, 2020
Merged

consoleEncoder: put cloned jsonEncoder back to pool #852

merged 2 commits into from Aug 5, 2020

Commits on Jul 28, 2020

  1. consoleEncoder: put cloned jsonEncoder back to pool (uber-go#851) 

    consoleEncoder clone a jsonEncoder in `writeContext`, but never put back to pool after use.
This make zap do more memory allocations, and may increase gc time.
    @wyxloading
    wyxloading committed Jul 28, 2020
    Copy the full SHA
    4b59b9c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. chore: add comments 

    Co-authored-by: Prashant Varanasi <github@prashantv.com>
    @wyxloading @prashantv
    wyxloading and prashantv committed Jul 29, 2020
    Copy the full SHA
    48ec7aa View commit details
    Browse the repository at this point in the history