Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor CallerSkip when taking stack traces & add the StackSkip field #843

Merged
merged 8 commits into from Aug 18, 2020
Merged

Honor CallerSkip when taking stack traces & add the StackSkip field #843

merged 8 commits into from Aug 18, 2020

Commits on Jun 23, 2020

  1. Introduce UseCallerSkipForStacktrace & StackSkip 

    * UseCallerSkipForStacktrace configures the Logger to honor CallerSkip
when taking stacktraces.
* StackSkip is similar to Stack but allows
skipping frames from the top of the stack

Fixes uber-go#512, fixes uber-go#727
    @segevfiner
    segevfiner committed Jun 23, 2020
    Copy the full SHA
    017057e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2020

  1. Change takeStacktrace skip parameter to a value

    @segevfiner
    segevfiner committed Jul 25, 2020
    Copy the full SHA
    8e25507 View commit details
    Browse the repository at this point in the history

  2. Modify StackSkip doc

    @segevfiner
    segevfiner committed Jul 25, 2020
    Copy the full SHA
    c27b7e4 View commit details
    Browse the repository at this point in the history

  3. Added tests and fixed bugs

    @segevfiner
    segevfiner committed Jul 25, 2020
    Copy the full SHA
    3410fce View commit details
    Browse the repository at this point in the history

  4. Fix failing test

    @segevfiner
    segevfiner committed Jul 25, 2020
    Copy the full SHA
    33c1b16 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Make UseCallerSkipForStacktrace the default, removing the option 

    Also remove the zap frame skipping logic in favour of zap setting the
skip correctly when taking the stack trace.
    @segevfiner
    segevfiner committed Aug 5, 2020
    Copy the full SHA
    80d2017 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Code review fix

    @segevfiner
    segevfiner committed Aug 12, 2020
    Copy the full SHA
    066ee2d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. Code review fixes for tests

    @segevfiner
    segevfiner committed Aug 15, 2020
    Copy the full SHA
    fc5ed1d View commit details
    Browse the repository at this point in the history