Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IncreaseLevel being reset after With #812

Merged
merged 2 commits into from Apr 11, 2020
Merged

Fix IncreaseLevel being reset after With #812

merged 2 commits into from Apr 11, 2020

Commits on Apr 3, 2020

  1. Fix IncreaseLevel being reset after With 

    Fixes #810

We missed implementing the increase-level logic in With
and since Core was embedded, we wended up using With from
the original core.

To avoid this sort of issue, avoid embedding and implement all
Core methods explicitly. This lets us consider the behaviour
of each method explicitly.
    @prashantv
    prashantv committed Apr 3, 2020
    Copy the full SHA
    ee180f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Add coverage for Write + Sync

    @prashantv
    prashantv committed Apr 11, 2020
    Copy the full SHA
    3ede7e8 View commit details
    Browse the repository at this point in the history