Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop library level constraints on tools #795

Merged
merged 2 commits into from Mar 5, 2020
Merged

Drop library level constraints on tools #795

merged 2 commits into from Mar 5, 2020

Commits on Mar 4, 2020

  1. Drop library-level constraints on tools 

    This renames tools.go to tools_test.go so that tool/development
dependencies are not considered transitive dependencies by `go mod`.

(We upgrade multierr and atomic to the most recent releases with a
similar fix.)

Refs T5279939
    @abhinav
    abhinav committed Mar 4, 2020
    Copy the full SHA
    af49ae3 View commit details
    Browse the repository at this point in the history

  2. Add staticcheck and fix issues 

    This adds staticcheck as a linter to Zap and fixes issues found by it.
Specifically, it found a few unused unexported types and functions.
    @abhinav
    abhinav committed Mar 4, 2020
    Copy the full SHA
    dd95ca6 View commit details
    Browse the repository at this point in the history