Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buffering wrapper around WriteSyncer #782

Closed
wants to merge 55 commits into from
Closed

Add buffering wrapper around WriteSyncer #782

wants to merge 55 commits into from

Commits on Oct 13, 2020

  1. add buffer sync

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    5f22c26 View commit details
    Browse the repository at this point in the history

  2. support config bufferSize and flushInterval, improve logic

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    36d1a4f View commit details
    Browse the repository at this point in the history

  3. improve

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    9f7be81 View commit details
    Browse the repository at this point in the history

  4. update comment

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    c1f54ca View commit details
    Browse the repository at this point in the history

  5. WriterSyncer support Close method

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    93832bc View commit details
    Browse the repository at this point in the history

  6. improve

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    ba42206 View commit details
    Browse the repository at this point in the history

  7. fix spell

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    069d7b9 View commit details
    Browse the repository at this point in the history

  8. improve cancel logic

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    60350a2 View commit details
    Browse the repository at this point in the history

  9. improve

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    1c24017 View commit details
    Browse the repository at this point in the history

  10. remove close

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    6ab72db View commit details
    Browse the repository at this point in the history

  11. rename cancel to close and keep syncing

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    bfd7a94 View commit details
    Browse the repository at this point in the history

  12. fix lint

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    66b7878 View commit details
    Browse the repository at this point in the history

  13. 100% test coverage

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    5e98dbb View commit details
    Browse the repository at this point in the history

  14. improve comment

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    5980ec9 View commit details
    Browse the repository at this point in the history

  15. improve comment

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    7f5913c View commit details
    Browse the repository at this point in the history

  16. fix test error

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    07b0e3a View commit details
    Browse the repository at this point in the history

  17. fix race condition in test case

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    dfdb0c2 View commit details
    Browse the repository at this point in the history

  18. 100% test coverage

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    c8b9979 View commit details
    Browse the repository at this point in the history

  19. add loop and fix typo

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    6d9018f View commit details
    Browse the repository at this point in the history

  20. Update zapcore/write_syncer.go 

    Co-authored-by: Prashant Varanasi <github@prashantv.com>
    @sysulq @prashantv
    2 people authored and liqi committed Oct 13, 2020
    Copy the full SHA
    f61fe13 View commit details
    Browse the repository at this point in the history

  21. improve test

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    7954bcf View commit details
    Browse the repository at this point in the history

  22. validate loop logic in test case

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    6e6e6f6 View commit details
    Browse the repository at this point in the history

  23. group default config

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    1e7da7f View commit details
    Browse the repository at this point in the history

  24. improve close logic

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    c427af2 View commit details
    Browse the repository at this point in the history

  25. Update zapcore/write_syncer.go 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sysulq @abhinav
    2 people authored and liqi committed Oct 13, 2020
    Copy the full SHA
    1d00db7 View commit details
    Browse the repository at this point in the history

  26. Update zapcore/write_syncer_test.go 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sysulq @abhinav
    2 people authored and liqi committed Oct 13, 2020
    Copy the full SHA
    a17596e View commit details
    Browse the repository at this point in the history

  27. Update zapcore/write_syncer_test.go 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sysulq @abhinav
    2 people authored and liqi committed Oct 13, 2020
    Copy the full SHA
    ccd3608 View commit details
    Browse the repository at this point in the history

  28. Update zapcore/write_syncer_test.go 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sysulq @abhinav
    2 people authored and liqi committed Oct 13, 2020
    Copy the full SHA
    13cdf32 View commit details
    Browse the repository at this point in the history

  29. Update zapcore/write_syncer_test.go 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sysulq @abhinav
    2 people authored and liqi committed Oct 13, 2020
    Copy the full SHA
    a2a235b View commit details
    Browse the repository at this point in the history

  30. Update zapcore/write_syncer_test.go 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sysulq @abhinav
    2 people authored and liqi committed Oct 13, 2020
    Copy the full SHA
    0477c9d View commit details
    Browse the repository at this point in the history

  31. Update zapcore/write_syncer_test.go 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sysulq @abhinav
    2 people authored and liqi committed Oct 13, 2020
    Copy the full SHA
    16a2147 View commit details
    Browse the repository at this point in the history

  32. improve close logic and use goleak

    @sysulq
    sysulq authored and liqi committed Oct 13, 2020
    Copy the full SHA
    761c8e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Drop type CloseFunc 

    We'd like to avoid introducing a new top-level type if we can. Delete
the CloseFunc type in favor of returning a naked `func() error`.
    @abhinav
    abhinav committed Nov 2, 2020
    Copy the full SHA
    a2123c9 View commit details
    Browse the repository at this point in the history

  2. doc: Rewrite Buffer documentation

    @abhinav
    abhinav committed Nov 2, 2020
    Copy the full SHA
    1957050 View commit details
    Browse the repository at this point in the history

  3. Prefix default{BufferSize, FlushInterval} with _ 

    Per https://github.com/uber-go/guide/blob/master/style.md#prefix-unexported-globals-with-_
    @abhinav
    abhinav committed Nov 2, 2020
    Copy the full SHA
    371117f View commit details
    Browse the repository at this point in the history

  4. Buffer/close: return a bound method 

    Instead of returning an anonmyous function, return a bound method. The
bound method is named `close`, not `Close` to avoid accidentally
exposing an `io.Closer` interface.
    @abhinav
    abhinav committed Nov 2, 2020
    Copy the full SHA
    22a2427 View commit details
    Browse the repository at this point in the history

  5. Buffer/close: Close the channel instead of posting 

    For the channel that signals end of the goroutine, we should close it
instead of posting a single value to it.
    @abhinav
    abhinav committed Nov 2, 2020
    Copy the full SHA
    c0f68a9 View commit details
    Browse the repository at this point in the history

  6. _default{BufferSize, FlushInterval}: docs

    @abhinav
    abhinav committed Nov 2, 2020
    Copy the full SHA
    f57c09b View commit details
    Browse the repository at this point in the history

  7. buffer: Move loop into a method 

    Move the flush loop into its own method instead of spawning it in a
closure.
    @abhinav
    abhinav committed Nov 2, 2020
    Copy the full SHA
    70795cf View commit details
    Browse the repository at this point in the history

  8. buffer/close: stop the ticker 

    On close, stop the ticker from posting ticks to the channel.
    @abhinav
    abhinav committed Nov 2, 2020
    Copy the full SHA
    d61c899 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Update zapcore/write_syncer_test.go 

    Co-authored-by: Prashant Varanasi <github@prashantv.com>
    @sysulq @prashantv
    sysulq and prashantv committed Nov 6, 2020
    Copy the full SHA
    20fc7a8 View commit details
    Browse the repository at this point in the history

  2. Update zapcore/write_syncer.go 

    Co-authored-by: Prashant Varanasi <github@prashantv.com>
    @sysulq @prashantv
    sysulq and prashantv committed Nov 6, 2020
    Copy the full SHA
    319e6fe View commit details
    Browse the repository at this point in the history

  3. improve code style

    @sysulq
    sysulq committed Nov 6, 2020
    Copy the full SHA
    d293796 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/hnlq715/zap

    @sysulq
    sysulq committed Nov 6, 2020
    Copy the full SHA
    d439793 View commit details
    Browse the repository at this point in the history

  5. Update zapcore/write_syncer.go 

    Co-authored-by: Prashant Varanasi <github@prashantv.com>
    @sysulq @prashantv
    sysulq and prashantv committed Nov 6, 2020
    Copy the full SHA
    9613897 View commit details
    Browse the repository at this point in the history

  6. Update zapcore/write_syncer.go 

    Co-authored-by: Prashant Varanasi <github@prashantv.com>
    @sysulq @prashantv
    sysulq and prashantv committed Nov 6, 2020
    Copy the full SHA
    5160827 View commit details
    Browse the repository at this point in the history

  7. add comment

    @sysulq
    sysulq committed Nov 6, 2020
    Copy the full SHA
    37a503b View commit details
    Browse the repository at this point in the history

  8. Update zapcore/write_syncer.go 

    Co-authored-by: Prashant Varanasi <github@prashantv.com>
    @sysulq @prashantv
    sysulq and prashantv committed Nov 6, 2020
    Copy the full SHA
    bea2863 View commit details
    Browse the repository at this point in the history

  9. Update zapcore/write_syncer.go 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sysulq @abhinav
    sysulq and abhinav committed Nov 6, 2020
    Copy the full SHA
    c971509 View commit details
    Browse the repository at this point in the history

  10. update

    @sysulq
    sysulq committed Nov 6, 2020
    Copy the full SHA
    8c2cdfe View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Remove Lock/Unlock from tests

    @prashantv
    prashantv committed Jan 5, 2021
    Copy the full SHA
    1fe1117 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. remove double buffer check

    @sysulq
    sysulq committed Jan 6, 2021
    Copy the full SHA
    0cd98f3 View commit details
    Browse the repository at this point in the history

  2. set timer to zero

    @sysulq
    sysulq committed Jan 6, 2021
    Copy the full SHA
    fe04d61 View commit details
    Browse the repository at this point in the history

  3. remove errorWriter

    @sysulq
    sysulq committed Jan 6, 2021
    Copy the full SHA
    23ca47d View commit details
    Browse the repository at this point in the history

  4. add SyncBuffer

    @sysulq
    sysulq committed Jan 6, 2021
    Copy the full SHA
    2b0cf17 View commit details
    Browse the repository at this point in the history