Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to increase the level of a logger #775

Merged
merged 5 commits into from Jan 30, 2020
Merged

Add option to increase the level of a logger #775

merged 5 commits into from Jan 30, 2020

Commits on Jan 24, 2020

  1. [WIP] Add option to increase the level of a logger 

    We've had a few requests on how to change the level of a logger. With
the current APIs, it's not possible to reduce the log level (e.g., go
from Info to Debug), but it is possible to increase the level using
`WrapCore` with a custom filtering core.

Since it's a common request, I think we should add an option to make
this easy to use.

I want to make sure "increase" is part of the API to avoid confusion on
whether it can reduce the log level.

Fixes #774.
    @prashantv
    prashantv committed Jan 24, 2020
    Copy the full SHA
    ee0d923 View commit details
    Browse the repository at this point in the history

  2. Rename to IncreaseLevel, add tests

    @prashantv
    prashantv committed Jan 24, 2020
    Copy the full SHA
    1653481 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Update zapcore/increase_level.go 

    Co-Authored-By: Abhinav Gupta <abg@uber.com>
    @prashantv @abhinav
    prashantv and abhinav committed Jan 30, 2020
    Copy the full SHA
    056412c View commit details
    Browse the repository at this point in the history

  2. Update zapcore/increase_level_test.go 

    Co-Authored-By: Abhinav Gupta <abg@uber.com>
    @prashantv @abhinav
    prashantv and abhinav committed Jan 30, 2020
    Copy the full SHA
    cea780b View commit details
    Browse the repository at this point in the history

  3. CR comments

    @prashantv
    prashantv committed Jan 30, 2020
    Copy the full SHA
    a36ef68 View commit details
    Browse the repository at this point in the history