New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpclog.LoggerV2 logger #613
Conversation
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
- Coverage 97.38% 97.23% -0.16%
==========================================
Files 40 40
Lines 2102 2132 +30
==========================================
+ Hits 2047 2073 +26
- Misses 47 51 +4
Partials 8 8
Continue to review full report at Codecov.
|
@frankgreco please sign CLA. That should take only a few minutes. |
nothing happened by repush |
@frankgreco You should add the email address from commit to your GitHub profile. |
7b7e0f6
to
d97b356
Compare
d97b356
to
002ebdb
Compare
codecov check failed, but test and cla passed. PTAL. |
what the status? |
I modified with your latest commit, then the cla check passed! |
Fixes #534. |
Is there any progress? /cc @akshayjshah |
I believe this is done. Just waiting for a review. |
👀 |
Is there any progress so far? |
Fixed V() implementation based on #538.
Official grpclog.LoggerV2 implementation sets verbose level at initialization. So I adopt functional option to set verbose level.