Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpclog.LoggerV2 logger #613

Closed
wants to merge 2 commits into from
Closed

Conversation

kazegusuri
Copy link

Fixed V() implementation based on #538.

Official grpclog.LoggerV2 implementation sets verbose level at initialization. So I adopt functional option to set verbose level.

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #613 into master will decrease coverage by 0.15%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   97.38%   97.23%   -0.16%     
==========================================
  Files          40       40              
  Lines        2102     2132      +30     
==========================================
+ Hits         2047     2073      +26     
- Misses         47       51       +4     
  Partials        8        8
Impacted Files Coverage Δ
zapgrpc/zapgrpc.go 93.22% <88.57%> (-6.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bc79d...7b7e0f6. Read the comment docs.

@AlekSi
Copy link
Contributor

AlekSi commented Aug 29, 2018

@frankgreco please sign CLA. That should take only a few minutes.

@frankgreco
Copy link

@AlekSi

It seems that I have already signed the CLA.
screen shot 2018-08-29 at 8 43 39 am

You can verify from the username in that image and the username from my commits in this PR that they are the same.

Maybe we should get a repo admin involved?

@kazegusuri
Copy link
Author

nothing happened by repush

@AlekSi
Copy link
Contributor

AlekSi commented Sep 2, 2018

@kazegusuri
Copy link
Author

codecov check failed, but test and cla passed. PTAL.

@kazegusuri
Copy link
Author

what the status?

@frankgreco
Copy link

@kazegusuri

#538 (comment)

@kazegusuri
Copy link
Author

I modified with your latest commit, then the cla check passed!

@ZackButcher
Copy link

Fixes #534.

@zchee
Copy link
Contributor

zchee commented Nov 14, 2018

Is there any progress?

/cc @akshayjshah

@frankgreco
Copy link

I believe this is done. Just waiting for a review.

@vvakame
Copy link

vvakame commented Dec 4, 2018

👀

@at-ishikawa
Copy link

Is there any progress so far?
I really want this PR to be merged.

@kazegusuri kazegusuri closed this Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants