ci: Fix golangci-lint installation #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
arukiidou
changed the title
arukiidou
changed the title
abhinav
reviewed
Mar 27, 2024
abhinav
approved these changes
Mar 27, 2024
abhinav
changed the title
|
@r-hang @JacobOaks It looks like codecov token isn't set. https://github.com/uber-go/zap/actions/runs/8454727528/job/23160466933?pr=1424#step:6:48 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 53 53
Lines 2997 2997
=======================================
Hits 2958 2958
Misses 31 31
Partials 8 8 ☔ View full report in Codecov by Sentry. |
JacobOaks
added a commit
to JacobOaks/fx
that referenced
this pull request
Apr 2, 2024
Following uber-go/zap#1424 as an example, fix CI to use `--help` flag since `--version` is no longer accepted. (example issue: https://github.com/uber-go/fx/actions/runs/8469190208/job/23203935028?pr=1182)
sywhang
pushed a commit
to uber-go/fx
that referenced
this pull request
Apr 2, 2024
Following uber-go/zap#1424 as an example, fix CI to use `--help` flag since `--version` is no longer accepted. (example issue: https://github.com/uber-go/fx/actions/runs/8469190208/job/23203935028?pr=1182)
JacobOaks
added a commit
to JacobOaks/sally
that referenced
this pull request
Apr 29, 2024
Following uber-go/zap#1424 and uber-go/fx#1185 as examples. `--version` is no longer accepted. Use `--help` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint runno longer accepts--version,so the hack we employ to install it using the official action
no longer works.
This replaces the flag with
--help, and fixes broken CI.Resolves #1423