Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zapcore: Improve errors unit tests #1414

Merged
merged 2 commits into from Mar 7, 2024
Merged

zapcore: Improve errors unit tests #1414

merged 2 commits into from Mar 7, 2024

Commits on Feb 7, 2024

  1. zapcore: Support ObjectMarshaler for error types 

    Previously, implementing `ObjectMarshaler` on an error type was ignored
unless the error was logged with `zap.Any` or `zap.Object`. We should
respect the `ObjectMarshaler` instead as this is more flexible than the
basic `error` or `fmt.Formatter` interfaces.

Resolves uber-go#1365
    @justinhwang
    justinhwang committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6a4971d View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. zapcore: Slim down changes to unit test improvements only

    @justinhwang
    justinhwang committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c3d3011 View commit details
    Browse the repository at this point in the history