Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace os.TempDir usage with t.TempDir #1146

Merged
merged 4 commits into from Aug 15, 2022
Merged

Replace os.TempDir usage with t.TempDir #1146

merged 4 commits into from Aug 15, 2022

Commits on Aug 15, 2022

  1. Replace os.TempDir usage with t.TempDir 

    Current tests can leave files around if tests fail, and even though they
use rand, it's not seeded, different runs can share the same output file
which causes other failures (e.g., file exists when it's not expected
to).  Avoid this by using  t.TempDir which automatically removed after
tests have run.
    @prashantv
    prashantv committed Aug 15, 2022
    Copy the full SHA
    f07c4dd View commit details
    Browse the repository at this point in the history

  2. stacktrace_ext_test: Use t.Setenv 

    Instead of managing the environment variable manually,
use t.Setenv to set and restore its value.
    @abhinav
    abhinav committed Aug 15, 2022
    Copy the full SHA
    52e7143 View commit details
    Browse the repository at this point in the history

  3. stacktrace_ext_test: Oops, missing Setenv arg

    @abhinav
    abhinav committed Aug 15, 2022
    Copy the full SHA
    92567c3 View commit details
    Browse the repository at this point in the history

  4. buffered_write_syncer_bench_test: Use b.TempDir

    @abhinav
    abhinav committed Aug 15, 2022
    Copy the full SHA
    d526b0d View commit details
    Browse the repository at this point in the history