Commits on Apr 29, 2022

1. CheckWriteHook: Don't allow Noop action …

   In #1088, we deprecated the CheckWriteAction enum in favor of the new
   fully customizable CheckWriteHook. Unfortunately, this introduced a
   minor regression: it's now possible to set log.Fatal to no-op with
   WriteThenNoop.
   
   Such a configuration will break code that looks like the following:
   
   ```go
   f, err := os.Open(..)
   if err != nil {
       log.Fatal("Cannot open file", zap.Error(err))
   }
   
   // Control flow expects that if we get here,
   // f is valid and non-nil.
   // That's not the case if Fatal no-ops.
   
   fmt.Println(f.Name())
   ```
   
   This change fixes the regression by turning Noops into WriteThenFatal
   when logging Fatal log messages. This matches the old behavior.
   
   It further clarifies the documentation for CheckWriteHook so that users
   know to call runtime.Goexit or os.Exit in them. It's still possible to
   write a custom hook that no-ops the log.Fatal, but it requires a little
   extra effort from the user to do so.

   

   abhinav committed Apr 29, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 3baaae2
   • Browse repository at this point

   Copy the full SHA

   3baaae2 View commit details

   Browse the repository at this point in the history

2. Revert formatting change

   

   abhinav committed Apr 29, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for ba9689d
   • Browse repository at this point

   Copy the full SHA

   ba9689d View commit details

   Browse the repository at this point in the history