Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing modules download #1044

Merged
merged 2 commits into from Jan 4, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/go.yml
Expand Up @@ -38,7 +38,9 @@ jobs:
- name: Download Dependencies
run: |
go mod download
cd tools && go mod download
cd tools && go mod download && cd -
cd benchmarks && go mod download && cd -
cd zapgrpc/internal/test && go mod download && cd -
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use subshells to avoid cding back.

Suggested change
cd tools && go mod download && cd -
cd benchmarks && go mod download && cd -
cd zapgrpc/internal/test && go mod download && cd -
(cd tools && go mod download)
(cd benchmarks && go mod download)
(cd zapgrpc/internal/test && go mod download)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!


- name: Lint
if: matrix.latest
Expand Down