Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for Issue: #554 MapObjectEncoder does not match jsonEncoder #1017

Merged
merged 5 commits into from Nov 8, 2021
Merged

Fix bug for Issue: #554 MapObjectEncoder does not match jsonEncoder #1017

merged 5 commits into from Nov 8, 2021

Commits on Oct 3, 2021

  1. Fix for Issue: 

    MapObjectEncoder does not match jsonEncoder
(uber-go#554)

 Problem was that new openNamespaces that are created during AppendObject() call were not closed.

 Note, ONLY new openNamespaces that are created during AppendObject() are closed. If they were created at prior to AppendObject() call, it will remain open till EncodeEntry() call completes.
    @sammyrnycreal
    sammyrnycreal committed Oct 3, 2021
    Copy the full SHA
    82a8da2 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. go mod tidy

    @abhinav
    abhinav committed Nov 8, 2021
    Copy the full SHA
    0db1070 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into appendObject-OpenNamespaces-bug

    @abhinav
    abhinav committed Nov 8, 2021
    Copy the full SHA
    ecac142 View commit details
    Browse the repository at this point in the history

  3. another test

    @abhinav
    abhinav committed Nov 8, 2021
    Copy the full SHA
    0f33ed5 View commit details
    Browse the repository at this point in the history

  4. rename i to old

    @abhinav
    abhinav committed Nov 8, 2021
    Copy the full SHA
    9f6f2fc View commit details
    Browse the repository at this point in the history