zapgrpc upgrade for grpclog.LoggerV2

[geeknoid]

The latest gRPC releases support an expanded logger interface (https://github.com/grpc/grpc-go/blob/master/grpclog/loggerv2.go). It'd be great if zap's gRPC support was updated accordingly.

Thanks.

[frankgreco]

I just ran into this as well.

[frankgreco]

@geeknoid if you need an immediate workaround you can use:

[[constraint]]
  name = "go.uber.org/zap"
  branch = "grpclog-v2"
  source = "github.com/frankgreco/zap"

[geeknoid]

Thanks.

…

On Wed, Dec 20, 2017 at 1:02 PM, Frank B Greco Jr ***@***.***> wrote: @geeknoid <https://github.com/geeknoid> if you need an immediate workaround you can use: [[constraint]] name = "go.uber.org/zap" branch = "grpclog-v2" source = "github.com/frankgreco/zap" — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#534 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVucHfxjHH2o2BsKbgmbnni3mTNRO8Yxks5tCXX7gaJpZM4Qz_Wq> .

[roytman]

Hi @frankgreco , do you have any estimation time when the feature will be merged ? Thanks

[frankgreco]

@roytman This PR was held up because I still needed to implement LoggerV2.V(). I'll try to finish this in the next couple of weeks so that we can get this merged.

[roytman]

Many thanks for the update and of course for your work.

[AlekSi]

Gentle poke. grpclog.Logger is deprecated now. Would be nice to have LoggerV2-compatible implementation.

[prashantv]

This ended up adding significant API surface to the Sugar logger, which I don't think we want to do.

This wrapper can sit outside of zap, and in future we may provide the gRPC adapter in a sub-package rather than extending the Sugar logger's API to support the gRPC logger.

[ash2k]

This ended up adding significant API surface to the Sugar logger, which I don't think we want to do.

But #881 does not add any methods to the Sugar logger? In fact, it does not touch any files outside of zapgrpc directory.

[prashantv]

You're completely right, it already is in a subpackage, so it's fine to extend it. Reviewed #881