Replace os.TempDir usage with t.TempDir #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current tests can leave files around if tests fail, and even though they use rand, it's not seeded, different runs can share the same output file which causes other failures (e.g., file exists when it's not expected to). Avoid this by using t.TempDir which automatically removed after tests have run.
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 49 49
Lines 2146 2146
=======================================
Hits 2110 2110
Misses 28 28
Partials 8 8 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Instead of managing the environment variable manually, use t.Setenv to set and restore its value.
abhinav
approved these changes
Aug 15, 2022
| @@ -30,7 +30,7 @@ import ( | |||
|
|
|||
| func BenchmarkBufferedWriteSyncer(b *testing.B) { | |||
| b.Run("write file with buffer", func(b *testing.B) { | |||
| file, err := os.CreateTemp("", "log") | |||
| file, err := os.CreateTemp("", "test.log") | |||
There was a problem hiding this comment.
Why doesn't this use b.TempDir()?
Suggested change
| file, err := os.CreateTemp("", "test.log") | |
| file, err := os.CreateTemp(b.TempDir(), "test.log") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current tests can leave files around if tests fail, and even though they
use rand, it's not seeded, different runs can share the same output file
which causes other failures (e.g., file exists when it's not expected
to). Avoid this by using t.TempDir which automatically removed after
tests have run.