Remove util.TypeOf helper function #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply removes the helper function
util.TypeOf
. Although it shortens the call frompass.TypesInfo.TypeOf
, it increases the cognitive load such that we do not know which we should use in NilAway's codebase and we don't know ifutil.TypeOf
has any special handling (it doesn't!). Moreover, we're using a mixture of these two functionally-identical expressions in our codebase.Removal of such a helper function reduces confusions and helps maintainability.