chore: Drop support for Go < 1.20 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops support for versions of Go older than 1.20. With 1.20 being the minimum supported Go version, we can remove the pre_go120 code, and merge the post_go120 code. With Go 1.20's multi-error interface, our errorGroup interface is not necessary, but we need it for backwards compatibility. Also updates the documentation to suggest Go 1.20's interface instead of ours. The `Errors() []error` function is now an implementation detail.
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 1 -2
Lines 120 108 -12
=========================================
- Hits 120 108 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JacobOaks
approved these changes
Oct 11, 2023
|
Thanks @abhinav! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for versions of Go older than 1.20.
With 1.20 being the minimum supported Go version,
we can remove the pre_go120 code, and merge the post_go120 code.
With Go 1.20's multi-error interface, our errorGroup interface
is not necessary, but we need it for backwards compatibility.
Also updates the documentation to suggest Go 1.20's interface
instead of ours.
The
Errors() []errorfunction is now an implementation detail.