Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Combine for all nil scenarios #55

Merged
merged 9 commits into from Feb 28, 2022
Merged

Optimize Combine for all nil scenarios #55

merged 9 commits into from Feb 28, 2022

Commits on Feb 28, 2022

  1. Optimize Combine for all nil scenarios

    @jstroem
    jstroem committed Feb 28, 2022
    Copy the full SHA
    ad162f4 View commit details
    Browse the repository at this point in the history

  2. optimize for one error

    @jstroem
    jstroem committed Feb 28, 2022
    Copy the full SHA
    3d2b5ea View commit details
    Browse the repository at this point in the history

  3. Removed unused code

    @jstroem
    jstroem committed Feb 28, 2022
    Copy the full SHA
    6acb82d View commit details
    Browse the repository at this point in the history

  4. cleanup allocation tests

    @jstroem
    jstroem committed Feb 28, 2022
    Copy the full SHA
    22c7808 View commit details
    Browse the repository at this point in the history

  5. bench: Don't allocate slices inside the loop

    @abhinav
    abhinav committed Feb 28, 2022
    Copy the full SHA
    9a9809b View commit details
    Browse the repository at this point in the history

  6. Simplify solution

    @abhinav
    abhinav committed Feb 28, 2022
    Copy the full SHA
    2ca2005 View commit details
    Browse the repository at this point in the history

  7. Don't inspect slices of 0 or 1

    @abhinav
    abhinav committed Feb 28, 2022
    Copy the full SHA
    b63bdaa View commit details
    Browse the repository at this point in the history

  8. test/cover: Slice with a single non-nil error

    @abhinav
    abhinav committed Feb 28, 2022
    Copy the full SHA
    5842d36 View commit details
    Browse the repository at this point in the history

  9. better explain the comment about copying the slice

    @abhinav
    abhinav committed Feb 28, 2022
    Copy the full SHA
    c5a74ae View commit details
    Browse the repository at this point in the history