Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of Go 1.5 compatibility from Readme #86

Merged
merged 1 commit into from Dec 16, 2022
Merged

Conversation

rabbbit
Copy link
Contributor

@rabbbit rabbbit commented Dec 7, 2022

Fixes #85

We're no longer compatible with pre 1.16 since #79.

I'm opting for removing the version rather than updating it to 1.18 since we already have go.mod for this.

Adding a pointer to the Go release policy, but I also considered dropping the mentions altogether. Copied the copy from zap.

Fixes #85

We're no longer compatible with pre 1.16  since #79.

I'm opting for removing the version rather than updating it to 1.18 since we already have go.mod for this. 

Adding a pointer to the Go release policy, but I also considered dropping the mentions altogether. Copied the copy from `zap`.
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #86 (34af211) into master (5c9bf00) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files           5        5           
  Lines         138      138           
=======================================
  Hits          131      131           
  Misses          4        4           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sywhang sywhang merged commit 3465299 into master Dec 16, 2022
@sywhang sywhang deleted the remove-1.5 branch December 16, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goleak is no longer compatible with Go 1.5+
3 participants