Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cleanup option #78

Merged
merged 8 commits into from Sep 6, 2022
Merged

Add Cleanup option #78

merged 8 commits into from Sep 6, 2022

Commits on Sep 3, 2022

  1. Add Cleanup option 

    This adds Cleanup option which can be passed to VerifyTestMain and
VerifyNone. This takes in a function that will be executed at the
end of the leak verification.

Internal Ref: GO-888
    @sywhang
    sywhang committed Sep 3, 2022
    Copy the full SHA
    58660f1 View commit details
    Browse the repository at this point in the history

  2. coverage

    @sywhang
    sywhang committed Sep 3, 2022
    Copy the full SHA
    89fc1e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
    @sywhang @abhinav
    sywhang and abhinav committed Sep 6, 2022
    Copy the full SHA
    e2de3bd View commit details
    Browse the repository at this point in the history

  2. address code review

    @sywhang
    sywhang committed Sep 6, 2022
    Copy the full SHA
    a4d7ce5 View commit details
    Browse the repository at this point in the history

  3. teardown->cleanup

    @sywhang
    sywhang committed Sep 6, 2022
    Copy the full SHA
    0f56260 View commit details
    Browse the repository at this point in the history

  4. code review feedback

    @sywhang
    sywhang committed Sep 6, 2022
    Copy the full SHA
    9306252 View commit details
    Browse the repository at this point in the history

  5. delete redundant "cleanup = nil"

    @abhinav
    abhinav committed Sep 6, 2022
    Copy the full SHA
    a034565 View commit details
    Browse the repository at this point in the history

  6. VerifyNone: cleanup, opts.cleanup = opts.cleanup, nil

    @abhinav
    abhinav committed Sep 6, 2022
    Copy the full SHA
    cd5fa11 View commit details
    Browse the repository at this point in the history