Document incompatibility of VerifyNone with t.Parallel #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a known issue that goleak is incompatible with tests being run in parallel. * uber-go#16 * uber-go#83 Unfortunately, there is no real solution to this issue. * uber-go#16 (comment) * uber-go#83 (comment) * uber-go#83 (comment) This PR at least documents the incompatibility and suggests using `VerifyTestMain` instead.
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 5 5
Lines 234 234
=======================================
Hits 226 226
Misses 5 5
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
r-hang
approved these changes
Oct 12, 2023
sywhang
approved these changes
Oct 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a known issue that goleak is incompatible with tests being run in parallel.
Unfortunately, there is no real solution to this issue.
This PR at least documents the incompatibility
and suggests using
VerifyTestMaininstead.