Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dead code #79

Merged
merged 1 commit into from Sep 6, 2022
Merged

Cleanup dead code #79

merged 1 commit into from Sep 6, 2022

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Sep 3, 2022

This removes some dead code from the codebase which dates back to
Go 1.16 which is no longer supported.

Also update the Go version in go.mod to Go 1.18 (support for 1.17
ended a month ago ish).

@sywhang
Cleanup dead code
c672d3c 
This removes some dead code from the codebase which dates back to
Go 1.16 which is no longer supported.

Also update the Go version in go.mod to Go 1.18 (support for 1.17
ended a month ago ish).
@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #79 (c672d3c) into master (2dfebe8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files           5        5           
  Lines         119      119           
=======================================
  Hits          112      112           
  Misses          4        4           
  Partials        3        3

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sywhang sywhang requested a review from abhinav September 5, 2022 19:19
@sywhang sywhang merged commit 326e1c1 into uber-go:master Sep 6, 2022
@sywhang sywhang deleted the cleanup-dead-code branch September 6, 2022 02:20
@Syuparn Syuparn mentioned this pull request Dec 7, 2022
Closed
rabbbit added a commit that referenced this pull request Dec 7, 2022
@rabbbit
Remove mentions of Go 1.5 compatibility from Readme
34af211 
Fixes #85

We're no longer compatible with pre 1.16  since #79.

I'm opting for removing the version rather than updating it to 1.18 since we already have go.mod for this. 

Adding a pointer to the Go release policy, but I also considered dropping the mentions altogether. Copied the copy from `zap`.
@rabbbit rabbbit mentioned this pull request Dec 7, 2022
Merged
sywhang pushed a commit that referenced this pull request Dec 16, 2022
@rabbbit
Remove mentions of Go 1.5 compatibility from Readme (#86)
3465299 
Fixes #85

We're no longer compatible with pre 1.16  since #79.

I'm opting for removing the version rather than updating it to 1.18
since we already have go.mod for this.

Adding a pointer to the Go release policy, but I also considered
dropping the mentions altogether. Copied the copy from `zap`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinav abhinav abhinav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sywhang @abhinav